feat(io): add ResolvingFileIO to resolve FileIO by location scheme and forward vended credentials#828
Open
plusplusjiajia wants to merge 2 commits into
Open
Conversation
…d forward vended credentials
Contributor
|
Could we add an end-to-end test using the actual Arrow FileIO implementations? The current tests use mocks and don’t cover the full |
There was a problem hiding this comment.
Pull request overview
This PR introduces a core ResolvingFileIO that selects the concrete FileIO implementation based on each file path’s URI scheme (instead of inferring from warehouse), and updates the REST catalog defaults and S3 credential handling to match Iceberg Java semantics for vended credentials.
Changes:
- Add
ResolvingFileIO(core) with per-scheme resolution, lazy loading viaFileIORegistry, caching, and forwarding of vended storage credentials. - Change REST catalog
MakeCatalogFileIOdefault toresolving-file-iowhenio-implis unset; remove warehouse-based auto-detection and compatibility checks. - Update
ArrowS3FileIO::SetStorageCredentialsto skip (not reject) non-S3 credential prefixes and warn when none are S3-compatible; add/adjust tests accordingly.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/iceberg/test/rest_file_io_test.cc | Updates REST FileIO tests for resolving default and logical-warehouse credential binding regression coverage. |
| src/iceberg/test/resolving_file_io_test.cc | Adds unit tests for scheme resolution, routing/caching behavior, and credential forwarding semantics. |
| src/iceberg/test/meson.build | Adds resolving_file_io_test.cc to Meson test sources. |
| src/iceberg/test/CMakeLists.txt | Adds resolving_file_io_test.cc to CMake test sources. |
| src/iceberg/test/arrow_s3_file_io_test.cc | Updates S3 FileIO credential-prefix behavior tests (skip non-S3; accept no-S3 case). |
| src/iceberg/resolving_file_io.h | Declares new ResolvingFileIO API and caching/credential-forwarding behavior. |
| src/iceberg/resolving_file_io.cc | Implements per-scheme resolution, lazy registry loading, caching, and credential forwarding. |
| src/iceberg/meson.build | Adds resolving_file_io.cc to core build sources and installs the new header. |
| src/iceberg/file_io_registry.h | Introduces the kResolvingFileIO registry name constant. |
| src/iceberg/file_io_registry.cc | Pre-registers resolving-file-io in the registry state constructor. |
| src/iceberg/CMakeLists.txt | Adds resolving_file_io.cc to core CMake sources. |
| src/iceberg/catalog/rest/rest_file_io.h | Removes builtin-detection declarations; documents resolving default behavior. |
| src/iceberg/catalog/rest/rest_file_io.cc | Defaults to resolving-file-io when io-impl is unset; simplifies table FileIO creation flow. |
| src/iceberg/arrow/s3/arrow_s3_file_io.cc | Skips non-S3 credential prefixes and logs a warning when all are skipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #719: replaces the temporary warehouse-based FileIO detection
with a scheme-based
ResolvingFileIO, mirroring Java.Why
The FileIO impl was picked from
DetectBuiltinFileIO(warehouse), so anynon-
s3://warehouse resolved toarrow-fs-localand binding vendedcredentials failed with
Configured FileIO does not support vended storage credentials. Credential-vending catalogs typically use a logical warehouseidentifier (bucket ARN / catalog name), not a storage URI, so the feature
only worked when
warehousewas literallys3://….What
ResolvingFileIO(core) — picks the impl per file-path scheme(
s3/s3a/s3n/oss→arrow-fs-s3;file/no scheme → local; elseNotSupported), lazily loaded viaFileIORegistryand cached; forwardsthe full credential list to impls that support it (Java
ResolvingFileIOsemantics). Registered asresolving-file-io.MakeCatalogFileIOdefaults toresolving-file-iowhen
io-implis unset (JavaDEFAULT_FILE_IO_IMPLlikewise); thewarehouse detection and the
io-impl-vs-warehouse check are removed.Explicit
io-implis honored as before.ArrowS3FileIO—SetStorageCredentialsskips non-S3 credentialprefixes instead of rejecting the set (Java
S3FileIOfilters by"s3");servers may vend credentials for several storage systems at once.